Fix union of template array-key with false losing the template - #6376
Open
calebdw wants to merge 1 commit into
Open
Fix union of template array-key with false losing the template#6376calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
TypeCombinator flattened TemplateBenevolentUnionType into int|string before adding other members, so TKey|false became int|string|false instead of substituting TKey.
Collaborator
|
You've opened the pull request against the latest branch 2.3.x. PHPStan 2.3 is not going to be released for months. If your code is relevant on 2.2.x and you want it to be released sooner, please rebase your pull request and change its target to 2.2.x. |
Contributor
|
please see issue-bot results, as it seems to fix/affect more open issues. please add regression tests where you see fit. in addition please have a look whether CI benchmark failling is a real regression. just try to run the offending benchmarks on a local machine (CI is sometimes flaky at this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
TypeCombinatorflattenedTemplateBenevolentUnionTypeintoint|stringbefore adding other members, soTKey|falsebecameint|string|falseinstead of substitutingTKey.Thanks!