Report values assigned to variables that are never read - #6330

Open

ondrejmirtes wants to merge 101 commits into

2.3.xfrom

unused-variables

Commits on Sep 1, 2026

Accept precomputed operand types in RicherScopeGetTypeHelper

ondrejmirtes
and
claude
committed
b1a7bbd
Let ExpressionResult own its expression's type and narrowing

ondrejmirtes
and
claude
committed
214dc71
Store whole ExpressionResults instead of before-scopes

ondrejmirtes
and
claude
committed
f58150f
Compose default narrowing from walk results in DefaultNarrowingHelper

ondrejmirtes
and
claude
committed
205bc3e
Replace EqualityTypeSpecifyingHelper with result-composed IdenticalNarrowingHelper

ondrejmirtes
and
claude
committed
c754216
Compose boolean narrowing from operand results

ondrejmirtes
and
claude
committed
0119cd2
Fold leaf handler type resolution into result callbacks

ondrejmirtes
and
claude
committed
dad1995
Fabricate virtual expression results equal to walked ones

ondrejmirtes
and
claude
committed
d663442
Rework the call handlers around preliminary results and ArgsResult

ondrejmirtes
and
claude
committed
3d7297e
Read impossible-check verdicts from the call's own result

ondrejmirtes
and
claude
committed
b96496c
Inline nullsafe short-circuiting and compose receiver narrowing

ondrejmirtes
and
claude
committed
0202a67
Fetch handlers read operand results

ondrejmirtes
and
claude
committed
3d29bfa
Resolve isset, empty and coalesce from chain results

ondrejmirtes
and
claude
committed
659f52d
Decompose ternary and match through composed narrowing

ondrejmirtes
and
claude
committed
5b077bc
Build closure types eagerly from the single body walk

ondrejmirtes
and
claude
committed
6ef627c
Thread assigned-value results through the assignment handlers

ondrejmirtes
and
claude
committed
d5204bf
Answer type and narrowing questions from stored ExpressionResults

ondrejmirtes
and
claude
committed
55b090e
Drop resolveType() and specifyTypes() from ExprHandler

ondrejmirtes
and
claude
committed
34cde3a
Short-circuit ScopeOps scans over conditional expressions

ondrejmirtes
and
claude
committed
7c6de54
Emit node callbacks after the node's results are stored
ondrejmirtes
committed
cb0b6fa
Emit condition-statement and assign-target callbacks after their results are stored
ondrejmirtes
committed
2a9ae83
Prime the storage for constructor return-type and type-specifying extensions
ondrejmirtes
committed
41babc9
Sum the output-buffer level without walking a synthetic node
ondrejmirtes
committed
175b9e6
Compose static-call and clone-with types without synthetic-node walks
ondrejmirtes
committed
cca907f
Read $this from scope state and document the parent-instantiation walk
ondrejmirtes
committed
6517ac1
Memoize function and constant name resolution in BetterReflectionProvider
ondrejmirtes
committed
4452315
Restore the non-type-driven fast path for the resolved acceptor
ondrejmirtes
committed
6f68473
Degrade on-demand walks of handler-less nodes to mixed
ondrejmirtes
committed
3b8169d
Guard FiberScope stored-result reads with the asking scope's variable state
ondrejmirtes
committed
0247b11
Consult ExpressionTypeResolverExtensions in every ExpressionResult read path
ondrejmirtes
committed
5d4d3f9
Memoize a full ExpressionTypeResolverExtension decline per result
ondrejmirtes
committed
c3e8cc7
Anchor rule-started walks to the MutatingScope
ondrejmirtes
committed
b770313
Remove the fiber suspension machinery
ondrejmirtes
committed
12e29bd
Serve node callbacks the storage-backed scope on every PHP version
ondrejmirtes
committed
2a6a30f
Rename FiberScope to NodeCallbackScope
ondrejmirtes
committed
04601da
Rename toMutatingScope to toWalkScope
ondrejmirtes
committed
4df6ab1
Keep deprecated toMutatingScope() and reset per-file state at the file boundary only
ondrejmirtes
committed
556e6c7
Memoize node-callback type asks by node identity
ondrejmirtes
committed
a3772b3
Remove unnecessary EXTENSION_TAG from ExprHandler
ondrejmirtes
committed
10cde0d
Align the extracted stmt handlers with the single-pass engine seam
ondrejmirtes
committed
5aa3c3a
Read argument and gathered-expression types from stored ExpressionResults
ondrejmirtes
committed
199f9c9
Price NewHandler's synthetic nodes through the sanctioned on-demand walk
ondrejmirtes
committed
72d3217
Extract function-call scope effects into FuncCallScopeEffectsHelper
ondrejmirtes
committed
b3e167b
Emit the closure and arrow-function argument callbacks after their results are stored
ondrejmirtes
committed
b8917e5
Emit intermediate assign-target links after their dimensions are processed
ondrejmirtes
committed
048a0de
Store the AssignOp result before applyWrite() emits assignment nodes
ondrejmirtes
committed
ac3734a
Defer Unset_, ClassConst, Const_ and While_ statement callbacks past their expressions
ondrejmirtes
committed
c4652f3
Read tracked state and constant expressions without pricing in resolveScopeStateType
ondrejmirtes
committed
efeb005
Give lazy property-type inference a sanctioned independent-pass walk
ondrejmirtes
committed
cea137e
Build the offset-write chain after the root walk in doPrepareTarget()
ondrejmirtes
committed
7203b0f
Create method call impure points after the arguments are processed
ondrejmirtes
committed
2772130
Read closure use-variable native types from scope state
ondrejmirtes
committed
e06394f
Read immediately-invoked closure arguments without walking ahead
ondrejmirtes
committed
03f0634
Create constructor impure points after the arguments are processed
ondrejmirtes
committed
135015e
Consult the complex-union guard for tracked expressions in applySpecifiedTypes()
ondrejmirtes
committed
da2ace6
Short-circuit unchanged variables in askScopeVariableStateMatches()
ondrejmirtes
committed
0b26f7c
Adopt the upstream convergence replay implementation

ondrejmirtes
and
claude
committed
e4bbca0
Adopt the upstream gatherer frames

ondrejmirtes
and
claude
committed
84cad32
Store the inc/dec results before the virtual assign emits assignment nodes
ondrejmirtes
committed
698107f
Resolve the arrow function body's return type from its stored result
ondrejmirtes
committed
ebed19f
Re-price untracked isset chain links on the asking scope in rule-facing resolutions
ondrejmirtes
committed
a5cf15b
Keep the nullsafe short-circuit's null in specified-type derivations and remembered call values
ondrejmirtes
committed
93a6003
Derive truthy/falsey override scopes lazily from the source result
ondrejmirtes
committed
7adb021
Require a call argument's captured ExpressionResult to exist
ondrejmirtes
committed
1185f1a
Carry the ending expression's result on ExecutionEndNode
ondrejmirtes
committed
37dbf79
Decide the scope-state reads whose synthetic fallback never fires
ondrejmirtes
committed
94f4e9a
Read a conditional-holder condition through its own ExpressionResult
ondrejmirtes
committed
66ac896
Keep void out of the value type of everything but a resolved call
ondrejmirtes
committed
19b5348
Resolve late-resolvable types when reading a tracked holder
ondrejmirtes
committed
352b7e9
Pass the storage argument positionally
ondrejmirtes
committed
af5fa04
Read a variable-variable from the tracked expressions
ondrejmirtes
committed
9137fcf
Keep the tracked type when there is no void to keep
ondrejmirtes
committed
5e10d2d
Build a match arm's filtering haystack from the conditions' types
ondrejmirtes
committed
18af23a
Walk a closure argument of a nullsafe call's plain twin
ondrejmirtes
committed
8a15862
Key the fully plain twin of a truthy nullsafe chain
ondrejmirtes
committed
769b091
Do not remember an impure call's value through its asserts
ondrejmirtes
committed
ee96e88
Price a for loop's exit condition on the generalized scope
ondrejmirtes
committed
32983e5
Read count()'s mode argument from its stored result only
ondrejmirtes
committed
fbe41e8
Answer a nullsafe chain link's state without walking it
ondrejmirtes
committed
5ecb397
Answer rule-side asks from results instead of the unwalked scope
ondrejmirtes
committed
7ff8020
Exempt variable reads and literals from the new-world guard

ondrejmirtes
and
claude
committed
709581b
Price literal arguments from scope state in findScopeStateType

ondrejmirtes
and
claude
committed
d1df285
Fire the list item callback after its key is processed

ondrejmirtes
and
claude
committed
ac6e554
Pin the node in object-id keyed per-file caches

ondrejmirtes
and
claude
committed
3796f04
Device non-nullability of unpriceable chain links at the walk's completion

ondrejmirtes
and
claude
committed
46f742e
Walk an immediately invoked closure's arguments before the callee

ondrejmirtes
and
claude
committed
91e195f
Carry the assigned call's declared return type for by-ref closure uses

ondrejmirtes
and
claude
committed
321b3f3
Answer a walked argument-less call from its stored result in the state read

ondrejmirtes
and
claude
committed
6598741
Cache read-variable names on the AST node

ondrejmirtes
and
claude
committed
64b2122
Bump expected turbo version
ondrejmirtes
committed
2aca59b
Remove variable writes that are never read

ondrejmirtes
and
claude
committed
70def6c
Track local variable write sites and whether their value is read

ondrejmirtes
and
claude
committed
dd4232d
Add UnusedVariableRule reporting values assigned to variables that are never read

ondrejmirtes
and
claude
committed
0fa6af1
Bump expected turbo version
ondrejmirtes
committed
479feff
Count variable reads walked in consume-stored mode

ondrejmirtes
and
claude
committed
3381094
Keep variable write markers out of the native expression map

ondrejmirtes
and
claude
committed
24e9f85
Temporarily enable unusedVariable for everyone

ondrejmirtes
and
claude
committed
340fbae
Add regression test for #12789

ondrejmirtes
and
claude
committed
7ce93b4
Add regression test for #12012

ondrejmirtes
and
claude
committed
7f47a1c
Add regression test for #11483

ondrejmirtes
and
claude
committed
49cf967
Add regression test for #10202

ondrejmirtes
and
claude
committed
2441298