Allow forwarding a @pure-unless-callable-is-impure callback - #6224
Open
zonuexe wants to merge 2 commits into
Open
Allow forwarding a @pure-unless-callable-is-impure callback#6224zonuexe wants to merge 2 commits into
zonuexe wants to merge 2 commits into
Conversation
A @pure-unless-callable-is-impure function is pure as long as its flagged callback is pure. Forwarding that callback to another @pure-unless-callable-is-impure function was still reported as impure; such forwarded calls are now exempted.
Reading the per-parameter TrinaryLogic flag was an equivalent mutation here: a Maybe flag only comes from combining several acceptors, which cannot happen for the resolved function of a plain function call. Use the function-level map with array_key_exists instead, like the check above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#15075
A
@pure-unless-callable-is-impurefunction is pure as long as its flagged callback is pure. Forwarding that callback to another@pure-unless-callable-is-impurefunction was still reported as impure; such forwarded calls are now exempted.