Skip to content

Upgrade PHPBench to 1.7.0 and use aggregate-preview report#6067

Merged
staabm merged 1 commit into
phpstan:2.2.xfrom
dantleech:phpbench1.7
Jul 20, 2026
Merged

Upgrade PHPBench to 1.7.0 and use aggregate-preview report#6067
staabm merged 1 commit into
phpstan:2.2.xfrom
dantleech:phpbench1.7

Conversation

@dantleech

@dantleech dantleech commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

This PR updates PHPBench to 1.7.0 and use the unstable "aggregate-preview" report (which may have minor changes prior to a 2.0 release). The "preview" report includes a diff column.

image

cc @staabm

Updates PHPBench to 1.7.0 and use the unstable "aggregate-preview" report
that currently includes the _diff_ column.
@staabm

staabm commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

lets give it a try, thank you @dantleech

@staabm
staabm merged commit 4c2586e into phpstan:2.2.x Jul 20, 2026
454 of 455 checks passed
@staabm

staabm commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@dantleech looking at the CI result in https://github.com/phpstan/phpstan-src/actions/runs/29727370175/job/88303447395 it seems the result table misses the "diff" column?

or maybe I need to regenerate the baseline for the new version?

@dantleech

dantleech commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@staabm that run is prior to this PR being merged. I guess it's still runninng ... or .. I don't know 🤔

@dantleech

Copy link
Copy Markdown
Contributor Author

ah the run conditions were not triggered:

on:
  pull_request:
    paths:
      - 'src/**'
      - '.github/workflows/bench.yml'
      - 'tests/bench/**'
  push:
    branches:
      - "2.2.x"
    paths:
      - 'src/**'
      - '.github/workflows/bench.yml'
      - 'tests/bench/**'

@staabm

staabm commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

you are right. it works on the latest merged commit: https://github.com/phpstan/phpstan-src/actions/runs/29750977889/job/88381097334 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants