Repository navigation
feature_checks: add an activity24hours check - #49
Merged
Merged
Conversation
Checks the 24-hour block for the admin and for guests with and without its permission, and, when hidebots is on the board, that the index still loads with hidebots enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
feature_checks.pycheck forrmcgirr83/activity24hours:u_a24hrs_view. The check removes that grant again afterwards.rmcgirr83/hidebotsis on the board, it enables hidebots, checks the index still loads for a guest and the admin, and puts hidebots back as it was. This is the regression test for the TypeError fixed in phpbbmodders/activity24hours (separate PR). Without hidebots on the board, that part is skipped with a note.Claude ran it with
--seed-boardon seed-forum boards with phpBB 3.3.19 and phpBB master (SQLite): 10/10 on both with the fix, twice each; with the old listener, the hidebots part fails with HTTP 500 on both.tests/test-phpbb-test-board.shpasses locally.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code