Repository navigation
Show forum-list feed links through the new template event - #8
Merged
Merged
Conversation
phpBB 3.3.20 and 4.0 add forumlist_body_forum_desc_after (PHPBB-17748), requested for this extension. When the user's style has the event in its forumlist_body.html (directly or from a parent style), the links go in their own forumrow variable shown by that event instead of being appended to FORUM_DESC. Styles without it, including phpBB 3.3.19's Prosilver, keep the old behavior. The event request doc records the merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new forum-list template event for the feed links, and keeps development files out of the ZIP.
Forum-list links through
forumlist_body_forum_desc_after. phpBB 3.3.20 and 4.0 add this template event (PHPBB-17748, phpbb/phpbb#7095 and #7096), requested for this extension. Until now the links were appended toFORUM_DESC, which put markup inside a value styles treat as description text.forumrow.FEEDLINKS_FORUMLIST_LINKSvariable, shown by a newforumlist_body_forum_desc_after.htmltemplate.docs/events/records that the event request was merged.Packaging:
docs/and.editorconfigare now export-ignored. The ZIP carrieddocs/events/and.editorconfig.Testing. Claude ran, on this branch:
db-matrix.shon phpBB 3.3.19 and 4.0.0-a3-dev with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL. On 3.3.19 the links were appended to the description, and on 4.0 they came through the event. The check also covers the forum page, a valid RSS 2.0 feed, and no links for forums set to none, plus a disable/purge/enable round trip.php -l --stricton PHP 8.1 and 8.4, and the template accessibility check: no findings.🤖 Generated with Claude Code
Investigated and written by Claude on behalf of William Jacoby (bonelifer).