Skip to content

Refactor extension - #40

Merged
iMattPro merged 2 commits into
phpbb-extensions:mainfrom
iMattPro:updates
Oct 1, 2026
Merged

iMattPro merged 2 commits into
phpbb-extensions:mainfrom
iMattPro:updates

Conversation

@iMattPro

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (cd90941) to head (688412a).

Additional details and impacted files
@@              Coverage Diff              @@
##                main      #40      +/-   ##
=============================================
- Coverage     100.00%   99.70%   -0.30%     
- Complexity        84      101      +17     
=============================================
  Files              8        8              
  Lines            303      337      +34     
=============================================
+ Hits             303      336      +33     
- Misses             0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iMattPro
iMattPro requested a balanced review from Copilot September 30, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The migration placement and storage cache invalidation issues remain unresolved.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Comment thread migrations/m3_storage.php
Mass refactor, strengthen png file handling, better consistency

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Cross-cutting migration, caching, browser, and security-sensitive path changes warrant final human validation.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@iMattPro
iMattPro merged commit 87fea81 into phpbb-extensions:main Oct 1, 2026
29 checks passed
@iMattPro
iMattPro deleted the updates branch October 1, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants