You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes a bug and adds a feature to the docs sidebar.
Feature added: When you visit a page such as https://www.php.net/manual/es/function.strlen.php, the side menu scrolls all the way to the top, which is awkward from a UX perspective. What I do is detect the active element (in this example, it would be strlen), and automatically scroll to that item. If I didn’t explain that clearly, here’s a video comparison:
after.vs.before.mp4
Bug fixed: When using the J and K shortcuts to navigate through the items in the side menu, the scroll bar did not move. This PR fixes that!
I don't think the top navigation bar should be affected.
Oh, you mean the sidebar in the window, right? That's caused by the scrollIntoView() function, which affects the parent scrollbars (whenever necessary). Would you prefer an implementation that only affects the sidebar menu's scrollbar? I can get started on that 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug and adds a feature to the docs sidebar.
Feature added: When you visit a page such as https://www.php.net/manual/es/function.strlen.php, the side menu scrolls all the way to the top, which is awkward from a UX perspective. What I do is detect the active element (in this example, it would be strlen), and automatically scroll to that item. If I didn’t explain that clearly, here’s a video comparison:
after.vs.before.mp4
Bug fixed: When using the J and K shortcuts to navigate through the items in the side menu, the scroll bar did not move. This PR fixes that!