Repository navigation
Conversation
Member
Author
|
This was reported by @TristanInSec as a security issue but it is impacting just PHP-8.6 pre-release so it's handled as a normal bug. |
Girgias
reviewed
Nov 1, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Should we just throw value errors instead?
The PSK callbacks copied the user-returned identity and key into fixed-size buffers without checking their length. The constructor of Openssl\Psk enforces the limits, but unserialize() bypasses it, so an oversized string overflowed the buffer. Bound each length to its buffer before copying. Co-authored-by: Tristan Madani <1075304+TristanInSec@users.noreply.github.com>
bukka
force-pushed
the
openssl_tls_session_psk_overflow
branch
from
November 1, 2026 19:36
8522cc6 to
bf312fe
Compare
Member
Author
Yeah good point. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSK callbacks copied the user-returned identity and key into fixed-size buffers without checking their length. The constructor of Openssl\Psk enforces the limits, but unserialize() bypasses it, so an oversized string overflowed the buffer. Bound each length to its buffer before copying.