Repository navigation
Conversation
The session remove callback reads the listener stream from the SSL_CTX ex_data, but the context is shared with accepted connections and can outlive the listener. Closing the listener left a dangling pointer that the callback later dereferenced. Clear it on close when it refers to the stream being freed. The added test reproduces it via a TCP proxy and crashes under ASan without the fix.
Member
Author
|
I should note that this was reported by @cx-joao-cunhadasilva as a security issue but because it's not released yet, it's just a public fix. |
Girgias
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session remove callback reads the listener stream from the SSL_CTX ex_data, but the context is shared with accepted connections and can outlive the listener. Closing the listener left a dangling pointer that the callback later dereferenced. Clear it on close when it refers to the stream being freed.
The added test reproduces it via a TCP proxy and crashes under ASan without the fix.