Repository navigation
Conversation
lazerg
changed the title
Contributor
Author
|
The MACOS_ARM64_DEBUG_NTS failure is not from this change. ext/openssl fails to build against OpenSSL 4.1 deprecations, and other master PRs fail the same way. |
LamentXU123
approved these changes
Oct 27, 2026
ndossche
approved these changes
Oct 27, 2026
iliaal
approved these changes
Oct 27, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
Please rebase this onto PHP-8.4, which has the same issue and would benefit from the fix.
lazerg
force-pushed
the
fix/gh-24740-phar-tar-metadata-size
branch
from
October 27, 2026 12:07
f9030ed to
45d33c1
Compare
Contributor
Author
|
I rebased it onto PHP-8.4 and dropped the NEWS entry. The new test fails on 8.4 without the fix and passes with it. |
Member
|
Thanks, I'll merge after ci/cd passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tar parser passed the header size of a
.phar/.metadata*entry straight tophar_tar_process_metadata(), which allocates that many bytes before reading. A 1.5 KB tar claiming a 2 GB metadata entry hits the memory limit instead of failing to open. Now a size larger than the archive is rejected up front.Fixes #24740