Skip to content

[%pS migration] Use %pS in ext/xmlreader - #23174

Merged
DanielEScherzer merged 1 commit into
php:PHP-8.6from
DanielEScherzer:ps-migration-ext-xmlreader
Oct 30, 2026
Merged

DanielEScherzer merged 1 commit into
php:PHP-8.6from
DanielEScherzer:ps-migration-ext-xmlreader

Conversation

@DanielEScherzer

Copy link
Copy Markdown
Member

No description provided.

@DanielEScherzer

Copy link
Copy Markdown
Member Author

Usefulness analysis:

  • in xmlreader_write_property() the class name can contain null bytes (https://3v4l.org/EiAoh#v) so %pS is needed; property name cannot contain null bytes because the only values are those present in xmlreader_prop_handlers and none of those have null bytes, but is updated for consistency
  • in XMLReader::expand() the class name can contain null bytes (https://3v4l.org/G91cW#v) so %pS is needed

@DanielEScherzer
DanielEScherzer force-pushed the ps-migration-ext-xmlreader branch from 95bd84a to 9cabdb6 Compare October 3, 2026 19:44
@DanielEScherzer
DanielEScherzer changed the base branch from master to PHP-8.6 October 3, 2026 19:44
@DanielEScherzer
DanielEScherzer force-pushed the ps-migration-ext-xmlreader branch from 9cabdb6 to 3bb212b Compare October 5, 2026 00:12
@DanielEScherzer
DanielEScherzer marked this pull request as ready for review October 5, 2026 05:50
@DanielEScherzer
DanielEScherzer force-pushed the ps-migration-ext-xmlreader branch from 3bb212b to cbead25 Compare October 30, 2026 01:39
@DanielEScherzer
DanielEScherzer merged commit 8a5d674 into php:PHP-8.6 Oct 30, 2026
18 checks passed
@DanielEScherzer
DanielEScherzer deleted the ps-migration-ext-xmlreader branch October 30, 2026 20:38
DanielEScherzer added a commit that referenced this pull request Oct 30, 2026
* PHP-8.6:
  [`%pS` migration] Use `%pS` in ext/xmlreader (#23174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants