Skip to content

Zend: no need to fetch method name for constructor#22153

Merged
Girgias merged 1 commit into
php:masterfrom
Girgias:no-need-to-fetch-known-ctor-name
May 26, 2026
Merged

Zend: no need to fetch method name for constructor#22153
Girgias merged 1 commit into
php:masterfrom
Girgias:no-need-to-fetch-known-ctor-name

Conversation

@Girgias
Copy link
Copy Markdown
Member

@Girgias Girgias commented May 26, 2026

No description provided.

@Girgias Girgias requested a review from dstogov as a code owner May 26, 2026 11:05
@Girgias Girgias merged commit 3447c58 into php:master May 26, 2026
1 check passed
@Girgias Girgias deleted the no-need-to-fetch-known-ctor-name branch May 26, 2026 12:15
@ndossche
Copy link
Copy Markdown
Member

I wonder if the code was written that way because of case-insensitive function names.

@Girgias
Copy link
Copy Markdown
Member Author

Girgias commented May 29, 2026

sigh I guess, but this means I would need to check for the special private constructor in #19797 as it doesn't have a name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants