Repository navigation
ci: tag static builder images with the release version - #2758
Merged
Merged
Conversation
The prepare job only resolved the version on scheduled runs, so tag
pushes and dispatches on a tag computed the image tags with VERSION=dev
and never pushed static-builder-{musl,gnu}-X.Y.Z. Also drop the stale
-gnu suffix in the GNU inspect step, which was inspecting a leftover
static-builder-gnu-gnu image instead of the one just pushed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
There's no real reason to do this as the static builder images automatically fetch the newer source, unless I completely misremember. |
Contributor
Author
|
static-builder-gnu-1.13.3 on docker hub was only pushed by the scheduled job https://github.com/php/frankenphp/actions/runs/40045999652/job/120739780095 not the manual release here https://github.com/php/frankenphp/actions/runs/39954802534/job/120440160546 look at the Create GNU manifest list and push in each job... you will see manual release skips full semver tags while scheduled job push full semver tags |
Contributor
|
That wasn't actually my question, but I can answer it myself: the images actually do embed frankenphp source so the versioned tags serve a purpose... kind of. It's a lot of wasted docker images though. |
henderkes
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.13.3 release (run 39954802534) pushed only
static-builder-{musl,gnu}andstatic-builder-{musl,gnu}-sha-ae3d5b9. It never pushedstatic-builder-{musl,gnu}-1.13.3,-1.13or-1. Until now those tags have only shown up at the next nightly run.preparejob only resolves the version onschedule, so on a tag it randocker buildx bake --printwithVERSION: dev, and the manifest tag list had no semver tags. It now uses the tag name when the ref is a tag, the same waydocker.yamlalready does.-gnuto a tag that already ends ingnu, so it inspected a stalestatic-builder-gnu-gnuimage (last updated 2025-03-28) rather than the one just pushed, and passed. The extra suffix is removed.Tested on a fork with a dispatch on a throwaway
v9.9.9tag:preparegetsVERSION: v9.9.9, and with the same inputsbake --printgivesstatic-builder-gnu,-gnu-9,-gnu-9.9and-gnu-9.9.9(the same for musl). Thepushjob was not run.🤖 Generated with Claude Code