Skip to content

ext/odbc: document the row default value change to null in fetch_object/array/into (PHP 8.4) - #5768

Merged
jordikroon merged 3 commits into
php:masterfrom
lacatoire:odbc-fetch-row-default-null
Aug 17, 2026
Merged

ext/odbc: document the row default value change to null in fetch_object/array/into (PHP 8.4)#5768
jordikroon merged 3 commits into
php:masterfrom
lacatoire:odbc-fetch-row-default-null

Conversation

@lacatoire

Copy link
Copy Markdown
Member

The changelog rows of odbc_fetch_object(), odbc_fetch_array() and odbc_fetch_into() state only that row became nullable in PHP 8.4.0. They omit the accompanying change of default value, which is the part that changes behaviour for existing calls: the previous defaults -1 and 0 were row positions, whereas null means "fetch the next row", the semantics odbc_fetch_row() already had.

Sources

ext/odbc/odbc.stub.php, comparing the php-8.3.0 and php-8.4.0 tags:

8.3.0  odbc_fetch_object($statement, int $row = -1): stdClass|false
8.3.0  odbc_fetch_array($statement, int $row = -1): array|false
8.3.0  odbc_fetch_into($statement, &$array, int $row = 0): int|false
8.3.0  odbc_fetch_row($statement, ?int $row = null): bool

8.4.0  odbc_fetch_object($statement, ?int $row = null): stdClass|false
8.4.0  odbc_fetch_array($statement, ?int $row = null): array|false
8.4.0  odbc_fetch_into($statement, &$array, ?int $row = null): int|false
8.4.0  odbc_fetch_row(Odbc\Result $statement, ?int $row = null): bool

@kamil-tekiela

Copy link
Copy Markdown
Member

The parameter descriptions need to be aligned as well

@lacatoire
lacatoire force-pushed the odbc-fetch-row-default-null branch from 1c8ceb4 to 571f041 Compare August 17, 2026 11:13
@kamil-tekiela

Copy link
Copy Markdown
Member

Looks good to me, but I think you have to fix the simparas.

@jordikroon
jordikroon merged commit 5035039 into php:master Aug 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants