ext/odbc: document the row default value change to null in fetch_object/array/into (PHP 8.4) - #5768
Merged
Merged
Conversation
Member
|
The parameter descriptions need to be aligned as well |
lacatoire
force-pushed
the
odbc-fetch-row-default-null
branch
from
August 17, 2026 11:13
1c8ceb4 to
571f041
Compare
kamil-tekiela
approved these changes
Aug 17, 2026
Member
|
Looks good to me, but I think you have to fix the simparas. |
jordikroon
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog rows of
odbc_fetch_object(),odbc_fetch_array()andodbc_fetch_into()state only thatrowbecame nullable in PHP 8.4.0. They omit the accompanying change of default value, which is the part that changes behaviour for existing calls: the previous defaults-1and0were row positions, whereasnullmeans "fetch the next row", the semanticsodbc_fetch_row()already had.Sources
ext/odbc/odbc.stub.php, comparing thephp-8.3.0andphp-8.4.0tags: