Repository navigation
Close a marker-line sublist's paragraph at a block line - #319
Merged
Merged
Conversation
An item whose marker line opens another list (`- - para`, `- 1. para`,
`- : t`) kept the inner paragraph open when the next line opened a block
at or left of the inner marker's column. The unindented line after it was
then taken as lazy text:
- - para
```
tail
djot.js closes the inner item at the code fence, opens the code block in
the outer item and ends the list at `tail`. djot-php put `tail` in the
code block. The syntax description: a list item takes "one or more lines,
indented relative to the list marker", and only an open paragraph takes a
lazy line ("Because a paragraph can never be interrupted by another
block-level element"). The item tracker already closed a note's paragraph
this way; it now does the same for a list opened on the marker line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 93.14% 93.14%
- Complexity 4775 4776 +1
=========================================
Files 118 118
Lines 12732 12733 +1
=========================================
+ Hits 11859 11860 +1
Misses 873 873 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An item whose marker line opens another list (
- - para,- 1. para,- : t) kept the inner paragraph open when the next line opened a block at or left of the inner marker's column. The unindented line after that was taken as lazy text:djot.js closes the inner item at the fence, opens the code block in the outer item and ends the list at
tail. djot-php puttailin the code block. The same happened with a thematic break, a table or a reference definition in that position.The syntax description: a list item takes "one or more lines, indented relative to the list marker", and only an open paragraph takes a lazy line ("Because a paragraph can never be interrupted by another block-level element"). The item tracker already closed a note's paragraph this way (#315); it now does the same for a list opened on the marker line. Plain text at that column still continues the inner paragraph (
- - a,b).Documents with this shape render differently, so this is labeled
bc-breaking.Measured against djot.js
On the 4853 generated block-family inputs, djot-php differed from djot.js
9790d4don 799 after #318 and 788 with this change. None moved the other way. On the 1080 list item bodies from #316 nothing changed.