Repository navigation
Correct decimal documentation and add verified site checks - #32
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 97.53% 97.53%
Complexity 195 195
=========================================
Files 1 1
Lines 406 406
=========================================
Hits 396 396
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternatives page listed
shift(), parity checks andsum()as unavailable even though they are public APIs. The README also claimed precision could only be lost through trimming or rounding, while arithmetic can truncate at its configured scale.This corrects those claims and adds mappings for fixed-scale output and averages. Getting started now includes a complete Composer-autoloaded script with a command to run it. Installation remains the single package-install recipe, the README links to it, and the CakePHP integration links to its own setup guide. Existing branding is preserved, with inline code wrapping on mobile.
Comparisons now retain stored fractional digits when a legacy explicit zero scale is used. For example,
Decimal::create('1.9', 0)->compareTo(1)returns1instead of0. Source comments also describe cloning, equality and explicit zero scales correctly.Pull requests build and audit the documentation. Workflow checkout credentials are disabled, and Pages write permissions remain limited to deployment.
Validation:
0.3andbool(true).