Skip to content

Correct decimal documentation and add verified site checks - #32

Merged
dereuromark merged 3 commits into
masterfrom
maintenance/docs-php8-audit
Oct 11, 2026
Merged

dereuromark merged 3 commits into
masterfrom
maintenance/docs-php8-audit

Conversation

@dereuromark

@dereuromark dereuromark commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The alternatives page listed shift(), parity checks and sum() as unavailable even though they are public APIs. The README also claimed precision could only be lost through trimming or rounding, while arithmetic can truncate at its configured scale.

This corrects those claims and adds mappings for fixed-scale output and averages. Getting started now includes a complete Composer-autoloaded script with a command to run it. Installation remains the single package-install recipe, the README links to it, and the CakePHP integration links to its own setup guide. Existing branding is preserved, with inline code wrapping on mobile.

Comparisons now retain stored fractional digits when a legacy explicit zero scale is used. For example, Decimal::create('1.9', 0)->compareTo(1) returns 1 instead of 0. Source comments also describe cloning, equality and explicit zero scales correctly.

Pull requests build and audit the documentation. Workflow checkout credentials are disabled, and Pages write permissions remain limited to deployment.

Validation:

  • PHPUnit: 473 tests, 701 assertions, no deprecations or notices.
  • Coding standards and PHPStan level 8 pass.
  • 103 documented outputs or input rejections match the current code.
  • 2709 signed split, allocation and quotient/remainder checks pass.
  • The complete beginner script prints 0.3 and bool(true).
  • Documentation build and 55 PHP snippet syntax checks pass.
  • Browser navigation, local search, branding, light/dark themes and mobile layout pass.
  • npm audit reports no vulnerabilities.

@dereuromark dereuromark added bug Something isn't working documentation Improvements or additions to documentation labels Oct 11, 2026
Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:44
@dereuromark dereuromark added bug Something isn't working documentation Improvements or additions to documentation labels Oct 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (cf005ef) to head (2fbb0ea).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage     97.53%   97.53%           
  Complexity      195      195           
=========================================
  Files             1        1           
  Lines           406      406           
=========================================
  Hits            396      396           
  Misses           10       10           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@dereuromark
dereuromark merged commit d6ba7f3 into master Oct 11, 2026
8 checks passed
@dereuromark
dereuromark deleted the maintenance/docs-php8-audit branch October 11, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants