Repository navigation
Correct the toInt() upgrade note - #31
Merged
Merged
Conversation
The 1.x column claimed that toInt() with a rounding mode is not available. 1.4 accepts the call and ignores the argument, which lets callers switch before upgrading. The license header template is also kept out of the dist.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #31 +/- ##
=========================================
Coverage 95.81% 95.81%
Complexity 201 201
=========================================
Files 1 1
Lines 454 454
=========================================
Hits 435 435
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers found while re-checking
next:toInt(Decimal::ROUND_DOWN)is not available on 1.x. 1.4 accepts the call and ignores the argument, so the result is the same on both versions and callers can switch before upgrading. The table and a sentence below it now say so..license, the file header template, was shipped in the dist archive. It is export-ignored now.