Skip to content

Allowlist synthetic.ag (false positive - legitimate Solana dApp)#1829

Open
nightcode112 wants to merge 1 commit into
phantom:masterfrom
nightcode112:allowlist-synthetic-ag
Open

Allowlist synthetic.ag (false positive - legitimate Solana dApp)#1829
nightcode112 wants to merge 1 commit into
phantom:masterfrom
nightcode112:allowlist-synthetic-ag

Conversation

@nightcode112

@nightcode112 nightcode112 commented Jul 1, 2026

Copy link
Copy Markdown

synthetic.ag is a legitimate Solana dApp for trading fractional shares of real-world collectibles (fine art, sneakers, supercars, watches, trading cards). Fully on-chain and USDC-backed.

Adding it to whitelist.yaml as false-positive protection so the root domain and its subdomains (e.g. www.synthetic.ag) are not caught by fuzzy-matching. It is not a phishing or malicious site.

Solana mainnet program: J4JPx1Um5vbhu4LcFtMUAEjadjT6rogAhKzFHZRyindL

Summary by CodeRabbit

  • Chores
    • Expanded the allowed URL list to include synthetic.ag and its subdomains.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8563b179-ef10-40ba-a8cd-5f83e69ca1bb

📥 Commits

Reviewing files that changed from the base of the PR and between 5030186 and 0df9311.

📒 Files selected for processing (1)
  • whitelist.yaml

📝 Walkthrough

Walkthrough

This change adds two new whitelisted domain entries, synthetic.ag and *.synthetic.ag, to the whitelist.yaml file, alongside the existing nftplus.io entry.

Changes

Whitelist Update

Layer / File(s) Summary
Add synthetic.ag domains
whitelist.yaml
Adds synthetic.ag and the *.synthetic.ag wildcard pattern to the URL whitelist near the existing nftplus.io entry.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding synthetic.ag to the allowlist as a false positive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant