[PyTorch] Delegate delayed-scaling updates to RecipeState - #38
Open
pggPL wants to merge 1 commit into
Open
Conversation
Keep FP8GlobalStateManager responsible for iterating registered delayed-scaling buckets, while RecipeState subclasses define the corresponding update algorithm. Extract recipe-to-state dispatch so construction and global updates share one mapping. Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract the non-behavioral recipe-state refactor from #34.
FP8GlobalStateManagercontinues to own update timing and iteration over the existing delayed-scaling global buffers, while the correspondingRecipeStatesubclass owns the update algorithm.This does not change the global buffer registry, update cadence, or make non-delayed recipes stateful.
Type of change
Changes
RecipeStateresolution intoRecipeState.class_for_recipe.DelayedScalingRecipeState.reduce_and_update_global_state.Test plan
pytest -q tests/pytorch/test_recipe.pyplus targeted delayed-scalingCustomRecipeand fuser tests: 58 passed, 92 skipped.python -m pylint transformer_engine/pytorch/quantization.py: 10.00/10.main; the fuser variants pass in both cases.Checklist: