Skip to content

chore: remove unused dependencies - #2074

Merged
meskill merged 1 commit into
mainfrom
meskill-2026-11-19-chore--yko
Nov 19, 2026
Merged

meskill merged 1 commit into
mainfrom
meskill-2026-11-19-chore--yko

Conversation

@meskill

@meskill meskill commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

New rust now show warnings about unused deps - clean them up and make lock file smaller

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Metal bench (arm64) failed. 5 of 520 measures outside bounds.

suite throughput cpu/txn user cycles/txn user instr/txn kernel cycles/txn kernel instr/txn ctx/txn
pooler 19.67 (+2.2% ± 2.0%), bound +2% 18,366 (+2.7% ± 1.1%), bound +2% 31,404 (-0.0% ± 0.1%) 32,091 (+2.6% ± 3.8%) 50,777 (-0.2% ± 0.7%)
lb 20.13 (+2.7% ± 1.4%), bound +2% 19,013 (+2.9% ± 1.3%), bound +2% 32,329 (+0.0% ± 0.04%) 32,512 (+3.4% ± 2.0%) 52,059 (-0.2% ± 0.3%)
sharding-w2 32.19 (+0.3% ± 1.6%) 43,334 (+1.0% ± 1.3%) 94,957 (+0.0% ± 0.05%) 40,594 (-0.3% ± 2.8%) 53,635 (-0.0% ± 0.2%) 1.543 (-0.1% ± 0.04%)
sharding-w8 249,069 (-0.0% ± 2.4%) 28.59 (-0.1% ± 2.2%) 43,421 (+0.2% ± 2.6%) 50,501 (-0.0% ± 0.05%) 35,532 (-0.5% ± 2.2%) 42,390 (+0.1% ± 0.2%) 0.1732 (+1.0% ± 1.0%)
  • pooler: user cycles +2.7%, instructions flat. Unexplained.
  • lb: user cycles +2.9%, instructions flat. Unexplained.
Counters per txn
suite frontend stall l1i refill backend stall
pooler 8,375 (+8.6% ± 3.6%) 2,707 (+2.5% ± 1.6%)
lb 8,784 (+8.8% ± 3.5%) 2,769 (+2.5% ± 1.6%)
sharding-w2 18,518 (+2.9% ± 3.3%) 4,216 (+1.2% ± 1.8%)
sharding-w8 19,672 (+1.3% ± 5.4%) 4,080 (+1.0% ± 2.9%)
benchmark measure result baseline change bound
full_named_cached::having_distinct_limit alloc_count 535 527 +1.56% ± 1.30% +0%

Microbench: 506 of 507 measures within bounds.

Microbench latency: 1 benches changed more than 3%
benchmark latency baseline change instructions change
extended_cached::select_all_shards 1,852 ns 1,925 ns -3.80% ± 0.36% +0.00% ± 0.00%
Hot code per txn
path base head change
pooler 114.7 KB 114.8 KB +0.1 KB
sharding-w2 168.8 KB 167.8 KB -1.1 KB

pooler:

crate base head change
pgdog::frontend::client::query_engine 20.4 KB 20.3 KB -0.1 KB
tokio 18.5 KB 18.4 KB -0.1 KB
pgdog::backend::pool 17.7 KB 17.6 KB -0.1 KB
aws-lc (TLS crypto) 10.5 KB 10.5 KB +0.0 KB
rustls (TLS) 8.4 KB 8.4 KB +0.0 KB
pgdog::frontend (other) 8.1 KB 8.1 KB +0.0 KB
pgdog::backend::server 7.6 KB 7.7 KB +0.1 KB
other 6.1 KB 6.1 KB +0.1 KB
everything else 17.5 KB 17.8 KB +0.2 KB
function head change
pgdog::frontend::client::Client::run::{{closure}} 5.7 KB +0.0 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 5.4 KB +0.0 KB
pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}} 4.2 KB -0.1 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 3.4 KB +0.0 KB
tokio::runtime::task::raw::poll 3.2 KB -0.1 KB

sharding-w2:

crate base head change
pgdog::frontend::router 29.1 KB 28.6 KB -0.5 KB
pgdog::frontend::client::query_engine 21.5 KB 21.6 KB +0.1 KB
tokio 18.8 KB 18.3 KB -0.5 KB
pgdog::backend::pool 18.1 KB 18.2 KB +0.2 KB
aws-lc (TLS crypto) 12.9 KB 12.6 KB -0.4 KB
other 10.2 KB 10.0 KB -0.2 KB
pgdog::frontend (other) 8.8 KB 8.8 KB -0.1 KB
pgdog::backend::server 8.0 KB 8.4 KB +0.4 KB
everything else 41.4 KB 41.3 KB -0.1 KB
function head change
pgdog::frontend::client::Client::run::{{closure}} 6.2 KB -0.1 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 5.3 KB +0.1 KB
pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}} 4.1 KB +0.1 KB
pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que 3.8 KB +0.0 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 3.3 KB -0.1 KB
lb flamegraph vs 6b0e24d

lb

Open interactive for hover, zoom and search.

lb removed

Open interactive.

microbench flamegraph vs 6b0e24d

microbench

Open interactive for hover, zoom and search.

microbench removed

Open interactive.

pooler flamegraph vs 6b0e24d

pooler

Open interactive for hover, zoom and search.

pooler removed

Open interactive.

sharding-w2 flamegraph vs 6b0e24d

sharding-w2

Open interactive for hover, zoom and search.

sharding-w2 removed

Open interactive.

sharding-w8 flamegraph vs 6b0e24d

sharding-w8

Open interactive for hover, zoom and search.

sharding-w8 removed

Open interactive.

Logs

lb, microbench, pooler, sharding-w2, sharding-w8, verdict.json

Compared e64189d with 6b0e24d on m8g.metal-24xl (spot).

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Metal bench (x86) passed. All 520 measures within bounds.

suite throughput cpu/txn user cycles/txn user instr/txn kernel cycles/txn kernel instr/txn ctx/txn
pooler 34.91 (+0.5% ± 0.3%) 23,099 (+1.2% ± 0.5%) 32,775 (-0.0% ± 0.02%) 58,319 (+0.4% ± 0.5%) 38,554 (-0.0% ± 0.3%)
lb 35.94 (+0.4% ± 0.3%) 24,261 (+1.0% ± 0.6%) 33,736 (+0.0% ± 0.02%) 59,351 (+0.3% ± 0.4%) 39,200 (-0.0% ± 0.09%)
sharding-w2 56.57 (-0.0% ± 1.6%) 53,512 (-0.1% ± 2.5%) 98,693 (-0.0% ± 0.01%) 73,426 (+0.1% ± 2.0%) 43,110 (+0.0% ± 0.8%) 1.391 (+0.2% ± 0.4%)
sharding-w8 146,409 (-0.5% ± 4.5%) 48.68 (+0.6% ± 3.3%) 57,910 (+0.5% ± 0.6%) 54,239 (+0.1% ± 0.3%) 65,745 (+0.8% ± 6.0%) 34,259 (+0.1% ± 0.3%) 0.1749 (+0.7% ± 6.3%)
Counters per txn
suite frontend stall l1i refill backend stall
pooler 74,749 (+2.4% ± 0.7%) 3,707 (+1.0% ± 0.2%)
lb 78,585 (+2.7% ± 1.5%) 3,826 (+0.9% ± 0.2%)
sharding-w2 166,307 (+0.4% ± 6.1%) 6,293 (-0.6% ± 1.5%)
sharding-w8 128,998 (+2.1% ± 1.4%) 5,042 (-0.0% ± 0.5%)

Microbench: all 507 measures within bounds.

Microbench latency: 19 benches changed more than 3%
benchmark latency baseline change instructions change
extended_cached::delete_by_key 2,184 ns 2,299 ns -5.00% ± 0.37% +0.00% ± 0.00%
extended_cached::set 1,441 ns 1,513 ns -4.76% ± 0.36% +0.00% ± 0.00%
extended_cold::select_omni 3,629 ns 3,795 ns -4.37% ± 0.86% +0.00% ± 0.00%
extended_cold::select_all_shards 4,003 ns 4,174 ns -4.09% ± 1.40% +0.00% ± 0.00%
extended_cached::begin 1,336 ns 1,390 ns -3.88% ± 0.78% +0.00% ± 0.00%
extended_cold::select_by_key 4,827 ns 5,017 ns -3.78% ± 0.53% +0.00% ± 0.00%
extended_cached::delete_all_shards 1,748 ns 1,816 ns -3.74% ± 0.72% +0.00% ± 0.00%
extended_cached::select_omni 2,024 ns 2,102 ns -3.71% ± 0.76% +0.00% ± 0.00%
extended_cached::update_by_key 2,368 ns 2,456 ns -3.58% ± 0.65% +0.00% ± 0.00%
extended_cold::delete_all_shards 2,939 ns 3,047 ns -3.54% ± 1.57% +0.00% ± 0.00%
extended_cached::insert_returning 2,324 ns 2,406 ns -3.42% ± 0.42% +0.00% ± 0.00%
extended_cached::distinct 2,376 ns 2,460 ns -3.41% ± 1.14% +0.00% ± 0.00%
extended_cached::update_all_shards 1,930 ns 1,996 ns -3.31% ± 0.55% +0.00% ± 0.00%
extended_cold::insert 6,237 ns 6,445 ns -3.22% ± 0.32% +0.00% ± 0.00%
simple_cold::delete_all_shards 2,841 ns 2,931 ns -3.07% ± 0.77% +0.00% ± 0.00%
extended_cached::join 3,856 ns 3,978 ns -3.06% ± 0.86% +0.00% ± 0.00%
extended_cold::aggregate 8,195 ns 8,453 ns -3.05% ± 0.65% +0.00% ± 0.00%
extended_cached::having 3,011 ns 3,105 ns -3.03% ± 0.72% +0.00% ± 0.00%
extended_cold::select_in_list 5,785 ns 5,965 ns -3.02% ± 0.49% +0.00% ± 0.00%
Hot code per txn
path base head change
pooler 107.9 KB 110.8 KB +2.9 KB
sharding-w2 167.4 KB 169.0 KB +1.6 KB

pooler:

crate base head change
pgdog::frontend::client::query_engine 20.9 KB 21.5 KB +0.6 KB
tokio 17.7 KB 17.7 KB +0.0 KB
pgdog::backend::pool 16.3 KB 16.6 KB +0.3 KB
pgdog::frontend (other) 9.3 KB 9.5 KB +0.2 KB
aws-lc (TLS crypto) 6.6 KB 7.7 KB +1.1 KB
pgdog::backend::server 7.1 KB 7.2 KB +0.1 KB
rustls (TLS) 7.0 KB 7.0 KB +0.0 KB
jemalloc 5.9 KB 5.9 KB +0.0 KB
everything else 17.0 KB 17.7 KB +0.7 KB
function head change
pgdog::frontend::client::Client::run::{{closure}} 7.3 KB +0.2 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 6.2 KB -0.2 KB
pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}} 4.2 KB -0.2 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 3.9 KB +0.3 KB
tokio::runtime::task::raw::poll 3.5 KB +0.0 KB

sharding-w2:

crate base head change
pgdog::frontend::router 27.7 KB 28.1 KB +0.4 KB
pgdog::frontend::client::query_engine 23.6 KB 23.8 KB +0.1 KB
pgdog::backend::pool 17.8 KB 18.1 KB +0.4 KB
tokio 18.1 KB 17.5 KB -0.6 KB
other 10.5 KB 10.8 KB +0.2 KB
pgdog::frontend (other) 10.8 KB 10.7 KB -0.1 KB
aws-lc (TLS crypto) 10.1 KB 10.5 KB +0.4 KB
jemalloc 9.9 KB 10.5 KB +0.6 KB
everything else 39.1 KB 39.1 KB +0.1 KB
function head change
pgdog::frontend::client::Client::run::{{closure}} 8.1 KB -0.1 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 6.2 KB +0.2 KB
pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}} 4.7 KB -0.1 KB
pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que 4.3 KB -0.1 KB
pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine: 4.0 KB -0.1 KB
lb flamegraph vs 6b0e24d

lb

Open interactive for hover, zoom and search.

lb removed

Open interactive.

microbench flamegraph vs 6b0e24d

microbench

Open interactive for hover, zoom and search.

microbench removed

Open interactive.

pooler flamegraph vs 6b0e24d

pooler

Open interactive for hover, zoom and search.

pooler removed

Open interactive.

sharding-w2 flamegraph vs 6b0e24d

sharding-w2

Open interactive for hover, zoom and search.

sharding-w2 removed

Open interactive.

sharding-w8 flamegraph vs 6b0e24d

sharding-w8

Open interactive for hover, zoom and search.

sharding-w8 removed

Open interactive.

Logs

lb, microbench, pooler, sharding-w2, sharding-w8, verdict.json

Compared e64189d with 6b0e24d on c7a.metal-48xl (spot).

@meskill
meskill force-pushed the meskill-2026-11-19-chore--yko branch from da25990 to e64189d Compare November 19, 2026 15:42
@jkaczman
jkaczman self-requested a review November 19, 2026 17:10
@meskill
meskill merged commit 5d27912 into main Nov 19, 2026
45 of 46 checks passed
@meskill
meskill deleted the meskill-2026-11-19-chore--yko branch November 19, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants