Repository navigation
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
Metal bench (arm64) passed. All 520 measures within bounds.
Counters per txn
Microbench: all 507 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json Compared 7bbe99a with 65f51c7 on c8g.metal-24xl (on-demand). |
Contributor
|
Metal bench (x86) passed. All 520 measures within bounds.
Counters per txn
Microbench: all 507 measures within bounds. Microbench latency: 3 benches changed more than 3%
Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json Compared 7bbe99a with 65f51c7 on c7i.metal-48xl (on-demand). |
levkk
approved these changes
Nov 19, 2026
murex971
force-pushed
the
murex-agg-sharding-key-lookup
branch
from
November 21, 2026 08:22
29d326e to
bcf5140
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groundwork for cross-shard
DISTINCTaggregates. No behaviour change.When
DISTINCTis on the sharding key, orGROUP BYincludes it, shardsnever share a value or a group, so per-shard results can be added up.
The aggregate rewrite needs to know when that is the case.
ShardedTables::sharding_keyso the rewrite can reuse it. The router calls the same method.
ShardingKey, which answers whether an expression or theGROUP BYis the sharding key of the table aSELECTreads. It onlyanswers for a single plain table and a bare column reference; joins,
subqueries, CTEs and expressions over the key are treated as "no".