Repository navigation
fix(cross-shard): detect DISTINCT on aggregates behind a cast - #2071
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Metal bench (arm64) passed. All 520 measures within bounds.
Counters per txn
Microbench: all 507 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json |
Contributor
|
Metal bench (x86) passed. All 520 measures within bounds.
Counters per txn
Microbench: all 507 measures within bounds. Microbench latency: 3 benches changed more than 3%
Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json |
levkk
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cross-shard
count(DISTINCT x)::intreturned the sum of each shard'sdistinct count. The
DISTINCTflag was only read when the aggregate wasthe top-level expression, so a cast hid it and the query was merged as a
plain
count.The flag is now read from the same call node as the function name, after
unwrapping casts. These queries get the same
0A000error as the uncastform: "count(DISTINCT ...) is not yet supported".
The same applies to
sum,avgand the variance functions.