Skip to content

PG server updates to fix llvm issue + Spock 5.0.9 updates#22

Open
maqeel75 wants to merge 3 commits into
mainfrom
spock-509-updates
Open

PG server updates to fix llvm issue + Spock 5.0.9 updates#22
maqeel75 wants to merge 3 commits into
mainfrom
spock-509-updates

Conversation

@maqeel75
Copy link
Copy Markdown
Member

@maqeel75 maqeel75 commented Jun 1, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR upgrades pgEdge PostgreSQL images from Spock 5.0.8 to 5.0.9 across all supported architectures and PostgreSQL versions. The change introduces a staging release channel and updates the Docker base image to use flexible pip installation.

Changes

Spock 5.0.9 release upgrade

Layer / File(s) Summary
Docker base image python3-pip flexibility
Dockerfile
The standard stage now uses wildcard version python3-pip-21.3.1-* instead of pinned python3-pip-21.3.1-1.el9 to allow flexibility during Patroni dependency installation.
AMD64 package manifests for Spock 5.0.9
packagelists/amd64/pg16.14-spock5.0.9-*.txt, packagelists/amd64/pg17.10-spock5.0.9-*.txt, packagelists/amd64/pg18.4-spock5.0.9-*.txt
Package lists for amd64 architecture updated across PostgreSQL 16.14, 17.10, and 18.4 to include Spock 5.0.9, PostgreSQL micro-revision bumps, and supporting Snowflake and LoLor components for both minimal and standard image flavors.
ARM64 package manifests for Spock 5.0.9
packagelists/arm64/pg16.14-spock5.0.9-*.txt, packagelists/arm64/pg17.10-spock5.0.9-*.txt, packagelists/arm64/pg18.4-spock5.0.9-*.txt
Package lists for arm64 architecture updated across PostgreSQL 16.14, 17.10, and 18.4 to include Spock 5.0.9, PostgreSQL micro-revision bumps, and supporting Snowflake and LoLor components for both minimal and standard image flavors.
Build script configuration for Spock 5.0.9 and staging release
scripts/build_pgedge_images.py
Build configuration updated to use spock_version=5.0.9 and package_release_channel="staging" for PostgreSQL 16, 17, and 18 image build profiles, replacing the prior Spock 5.0.8 versions.

Poem

🐰 A spicy upgrade hops along the way,
From 5.0.8 to 5.0.9 today!
Package lists dance on amd64 and arm64,
Staging channels staged, our images shine far.
Pip now flexible, Docker's ready to build—
PostgreSQL dreams about to be fulfilled! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether a description is present and related to the changeset. Add a pull request description explaining the purpose of the Spock 5.0.9 updates, what was changed, and why these changes are necessary.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main changes: PostgreSQL server updates related to an LLVM issue and upgrading Spock from 5.0.8 to 5.0.9 across multiple package lists and build configurations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spock-509-updates

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Jun 1, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Line 113: The dnf install call uses a wildcard RPM name
('python3-pip-21.3.1-*') which causes non-reproducible installs; introduce a
build ARG (e.g., PY3_PIP_NEVRA) and replace the wildcard with that exact NEVRA
value in the install command so the exact RPM is pinned, and use the same ARG
value for any later remove/cleanup (ensure the ARG is documented/defaulted in
the Dockerfile). Locate the install line that references python3-pip-21.3.1-*
and update it to use the new build argument (and update the corresponding
remove/cleanup invocation) so rebuilds use the exact NEVRA provided at build
time.

In `@scripts/build_pgedge_images.py`:
- Line 169: The script currently hardcodes package_release_channel="staging" in
multiple call sites; change those to read the channel from a configurable source
(e.g., an environment variable like PGEDGE_RELEASE_CHANNEL or a top-level config
variable) and default to "stable" when the env/config is unset; update all
occurrences that set package_release_channel (the three places shown) to use the
new config variable (or os.environ.get fallback) so builds can target the proper
release channel instead of always forcing "staging".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9a153c4-d040-4a3f-9d21-b59148b2b1d0

📥 Commits

Reviewing files that changed from the base of the PR and between a358b50 and 346e2ce.

📒 Files selected for processing (20)
  • Dockerfile
  • packagelists/amd64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/amd64/pg16.14-spock5.0.9-minimal.txt
  • packagelists/amd64/pg16.14-spock5.0.9-standard.txt
  • packagelists/amd64/pg17.10-spock5.0.8-minimal.txt
  • packagelists/amd64/pg17.10-spock5.0.9-minimal.txt
  • packagelists/amd64/pg17.10-spock5.0.9-standard.txt
  • packagelists/amd64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/amd64/pg18.4-spock5.0.9-minimal.txt
  • packagelists/amd64/pg18.4-spock5.0.9-standard.txt
  • packagelists/arm64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/arm64/pg16.14-spock5.0.9-minimal.txt
  • packagelists/arm64/pg16.14-spock5.0.9-standard.txt
  • packagelists/arm64/pg17.10-spock5.0.8-minimal.txt
  • packagelists/arm64/pg17.10-spock5.0.9-minimal.txt
  • packagelists/arm64/pg17.10-spock5.0.9-standard.txt
  • packagelists/arm64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/arm64/pg18.4-spock5.0.9-minimal.txt
  • packagelists/arm64/pg18.4-spock5.0.9-standard.txt
  • scripts/build_pgedge_images.py
💤 Files with no reviewable changes (6)
  • packagelists/amd64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/arm64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/amd64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/arm64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/amd64/pg17.10-spock5.0.8-minimal.txt
  • packagelists/arm64/pg17.10-spock5.0.8-minimal.txt

Comment thread Dockerfile
Comment thread scripts/build_pgedge_images.py
@maqeel75 maqeel75 changed the title Spock 509 updates PG server updates to fix llvm issue + Spock 5.0.9 updates Jun 1, 2026
@maqeel75 maqeel75 requested a review from mmols June 1, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant