New test stories added in ci/journey.sh

[imtiazqa]

TC-022 — Verifies that a wrong S3 endpoint causes the archiver to fail at Phase 2 with a clear connection error naming the bad host
TC-024 — Verifies that an empty (0-row) partition completes all six archiver phases cleanly and is dropped from PostgreSQL
TC-040 — Verifies that renaming the hot table triggers the DDL hook to update the registry and rebuild the view, and DML via the view continues to route correctly
TC-052 — Verifies that partitioner set --retention updates partition_config in the database without touching the YAML file
TC-053 — Verifies that a disabled table is silently excluded from archiver runs and re-enabling it restores normal processing
TC-054 — Verifies that partitioner remove deletes the partition_config row while leaving the physical table intact
TC-071 — Verifies that a composite PARTITION BY RANGE (col1, col2) key is rejected by the archiver before any Iceberg or S3 work
TC-118 — Verifies that an archiver.tables block in the YAML config is ignored at runtime; the archiver always drives off partition_config
TC-119 — Verifies that export → delete row → import restores a partition_config entry (backup/restore cycle works correctly)
TC-120 — Verifies that archiver set writes only to partition_config; the YAML config file on disk is not modified

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 39337d80-de3b-4e60-918f-5a6ed09f80d3

📥 Commits

Reviewing files that changed from the base of the PR and between 5335b87 and a900708.

📒 Files selected for processing (2)

• ci/journey.sh
• cmd/archiver/main.go

🚧 Files skipped from review as they are similar to previous changes (2)

• cmd/archiver/main.go
• ci/journey.sh

---

📝 Walkthrough

Walkthrough

Changes

Archiver and partitioner behavior

Layer / File(s)	Summary
Stale partition drop cleanup cmd/archiver/main.go	Already-archived partition cleanup now logs the condition and drops the partition without explicitly detaching it from its parent.
Configuration and partitioner management coverage ci/journey.sh	Adds TC-118, TC-119, TC-120, TC-040, TC-052, TC-053, and TC-054 for database-backed configuration, export/import, table renaming, retention, enablement, and removal; wires them into tiered execution.
Tiered archiver execution coverage ci/journey.sh	Adds TC-022, TC-024, and TC-071 for invalid S3 endpoints, empty partitions, and composite RANGE key rejection.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Suggested reviewers: vyruss

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: new test stories added in ci/journey.sh.
Description check	✅ Passed	The description directly matches the changed test stories and their behavior coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/automate-manual-tcs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[vyruss]

@imtiazqa Wait, how did this sneak into this PR? This is a regression, it's absolutely wrong to ACCESS EXCLUSIVE lock the entire partitioned table. The whole partMgr.Detach CONCURRENTLY mechanism was built specifically for this.