Conversation
peterxcli
added this pull request to stack #6
September 15, 2026 18:50
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to apache#24393. Stage 3 of the Parquet I/O stack, based on #5.
Stack, with each PR targeting its predecessor: #4 → #5 → #7 → #8 → #9.
Rationale for this change
Starting the next read after predicate evaluation misses an opportunity to overlap substantial scan CPU work with I/O.
What changes are included in this PR?
For upfront reads with prefetch enabled, start the successor read before evaluating the current row group's predicates. Keep pending work aligned with the decoder when filters silently eliminate a group; retain cancellation and demand-read fallback.
What is the testing strategy for this PR?
The predicate-overlap regression checks that the next read starts before predicate CPU work. Existing cases cover skipped groups, dynamic filters, ordering, cancellation, and memory release.
Workspace Clippy with all targets/features, the extended test suite, and the focused Parquet/queue checks passed on
lsa-cupid1. Tests use a private PID namespace, CPUs 96–111, and a 65,536 file limit.Full partitioned ClickBench on
lsa-cupid1,/work/peterxcliNVMe: 100 files, 99,997,497 rows, all 43 queries, eight workers/partitions. Versus the immediate parent, the sum of query medians changes -0.16% / -0.54% warm and -2.03% with evicted files (negative is faster). Warm values are two reversed-order passes; evicted files use three runs per query.Keep. Q21 with 8 ms added per read improves 24.09% versus the parent. Results and methodology · 43 per-query comparisons and CPU charts. Result-ordering limitations and synthetic-latency controls are documented in the report.
Are there any user-facing changes?
The existing opt-in prefetch starts earlier. No new setting or default change.