Fix repeat with named dataset arguments - #1769
Open
drewmt wants to merge 1 commit into
Open
Conversation
drewmt
marked this pull request as ready for review
July 24, 2026 22:38
drewmt
force-pushed
the
fix/repeat-named-datasets
branch
from
August 5, 2026 21:45
60e4173 to
85bacc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
repeat()prepends its iteration value to the data provider arguments and later moves it to the end before invoking the test. With named dataset arguments, appending that value as a positional argument causes PHP to throwCannot use positional argument after named argument.This keeps the existing positional behavior, maps the iteration value to the next test parameter when named arguments are used, and omits it when the test does not accept an iteration parameter. Regression coverage includes both named datasets with and without the repeat iterator.
The aggregate visual snapshots are updated for the eight additional repeated executions and twenty assertions.
Related:
Fixes #1767
Validation:
php bin/pest tests/Features/Repeat.php --compact— 142 tests, 327 assertionscomposer test:lintcomposer test:type:checkThe full local matrix was also attempted. Its remaining failures are limited to the existing macOS-specific
Backtraceexpectation and platform-dependent visual aggregate counts; the focused behavior, lint, static analysis, and type coverage pass.