fix: resolve $this type in ->with(), dataset closures, and trait-bound test cases - #9
Merged
Merged
Conversation
…e and related extensions
PHPStan treats traits as non-instantiable, so intersecting a class ObjectType with a trait ObjectType collapses to NEVER. Introduce PestTestCaseWithTraitsType, an ObjectType subclass that delegates to the test case class while also exposing methods/properties/constants from bound traits. Also extend PestConfigReader to treat uses()/pest()->... bindings without an ->in() scope as global bindings that apply to every test file, matching Pest runtime behavior. Closes pestphp/pest#1815
$this in ->with()
MrPunyapal
marked this pull request as ready for review
August 7, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two related gaps in
$thistype resolution inside Pest test closures.$thisin->with()and dataset closuresClosures passed to
->with()or used as array-dataset values now resolve$thisto the bound test case, so Laravel / PHPUnit helpers can be called without PHPStan reporting an undefined variable.Trait methods on
$thisWhen a trait is bound alongside a test case (or alone), PHPStan now recognizes methods, properties, and constants provided by that trait, instead of only looking at the class.
This works for
pest()->extend(...)->use(...), splitpest()->extend(...)/pest()->use(...)calls, file-leveluses(Trait::class), and any combination of classes and traits.Global Pest.php bindings
Bindings declared in
Pest.phpwithout->in('...')are now applied to every test file, matching Pest runtime behavior.Closes pestphp/pest#1815 and pestphp/pest#1827