fix: pass null to ReflectionProperty::setValue() for static Assert::$count - #244
Open
Kimtran-art wants to merge 1 commit into
Open
fix: pass null to ReflectionProperty::setValue() for static Assert::$count#244Kimtran-art wants to merge 1 commit into
Kimtran-art wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running browser tests on PHP 8.3+ emits, on essentially every assertion retry:
It comes from
Execution::resetAssertions().Assert::$countis a static property, so under PHP 8.3 the first argument tosetValue()must benull(or an object); passing the class-stringAssert::classtriggers the deprecation. On Firefox nearly every test retries once, so runs get flooded with the notice (tests still pass, but every test is labelled deprecated).Fix: pass
null, the canonical form for a static property - no behaviour change. The@phpstan-ignore-next-lineis dropped since the call is now valid.The same line exists on
5.xand is affected identically, if you'd like it forward-ported.