Skip to content

fix: detect visit() when wrapped in another function call #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pINKmUNster wants to merge 1 commit into
base: 4.x
Choose a base branch
from
+19 −1
Open

fix: detect visit() when wrapped in another function call #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Support/BrowserTestIdentifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ private static function usesFunction(Closure $closure, string $functionName): bo
return true;
}

return $tokens[$i - 1][0] === T_WHITESPACE;
return $tokens[$i - 1][0] === T_WHITESPACE || $tokens[$i - 1] === '(';
}
}

Expand Down
18 changes: 18 additions & 0 deletions tests/Unit/Support/BrowserTestIdentifierTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,24 @@ function callUsesFunction(Closure $closure, string $functionName): bool
expect(callUsesFunction($closure, 'visit'))->toBeTrue();
});

// visit detection — wrapped in another function call

it('detects visit() wrapped in another function call', function (): void {
$closure = function (): void {
acknowledgeEnvironment(visit('/'));
};

expect(callUsesFunction($closure, 'visit'))->toBeTrue();
});

it('detects \visit() wrapped in another function call', function (): void {
$closure = function (): void {
acknowledgeEnvironment(\visit('/'));
};

expect(callUsesFunction($closure, 'visit'))->toBeTrue();
});

// visit detection — Livewire

it('detects Livewire::visit()', function (): void {
Expand Down