Repository navigation
[ENHANCEMENT] Explore: select the default explorer without a state-syncing effect - #344
Merged
Gladorme merged 1 commit intoOct 2, 2026
Conversation
…ncing effect Derive the default explorer from the sorted plugin list in ViewExploreApp and pass it to the explorer manager provider. Signed-off-by: Guillaume LADORME <gladorme@gmail.com>
6 tasks
AntoineThebaud
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out of #319 to ease review (independent from the other split PRs, based on
main).Replace the
useEffectthat wrote the first explorer plugin into the store with a derived default.ViewExploreAppderives the default explorer from the sorted plugin list and passes it as the new optionaldefaultExplorerprop ofExplorerManagerProvider/ExplorerManagerProviderWithQueryParams. It is used while the store has no explorer selected and committed to the store on the first state change.getExplorerKey(plugin)anduseSortedExplorerPlugins()(shared by the tabs and the default selection, so the default always matches the first tab).ExploreManagerandExplorerManagerProvider.Validation on this branch:
npm run lint,npm run format:check,npm run type-checkandnpm run testall pass.Screenshots
No visual change.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: