Skip to content

fix(statchart): size auto tiles from the panel height - #850

Merged
shahrokni merged 9 commits into
perses:mainfrom
colivi:fix/statchart-auto-sparkline
Oct 5, 2026
Merged

shahrokni merged 9 commits into
perses:mainfrom
colivi:fix/statchart-auto-sparkline

Conversation

@colivi

@colivi colivi commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description

The hardcoded 72px cap left the rest of the panel empty and gave the sparkline no room under the series name and value.
Fix consists in sharing the panel height across rows instead, keeping the 60px minimum.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

The 72px cap left the rest of the panel empty and gave the sparkline
no room under the series name and value. Share the panel height across
rows instead, keeping the 60px minimum.

Signed-off-by: colivi <charles.olivi@gmail.com>
@colivi
colivi requested a review from a team as a code owner October 1, 2026 13:27
@colivi
colivi requested review from Gladorme and removed request for a team October 1, 2026 13:27
@shahrokni
shahrokni self-requested a review October 1, 2026 14:22
colivi added 3 commits October 1, 2026 16:26
Auto layout sized the number to 25% of the tile and gave the rest to the
chart, so Traffic distribution stayed tiny while the panel grew. Cap the
sparkline band and let the value use the remaining height, up to 96px.
Series names scale with the tile instead of sticking at 14px.

Signed-off-by: colivi <charles.olivi@gmail.com>
@colivi

colivi commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Screen captures of rendering:
-singe stats:
image

  • multi-series stats with sparkline:
image - multi-series stats without spakline: image

Comment thread statchart/src/StatChartBase.tsx Outdated
@shahrokni
shahrokni added this pull request to the merge queue Oct 5, 2026
Merged via the queue into perses:main with commit ecf8eba Oct 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants