[BUGFIX] pyroscope: include time range in lookup query keys - #849
Merged
Gladorme merged 1 commit intoOct 2, 2026
Merged
Conversation
Signed-off-by: luweglarz <lucas.weglarz@amadeus.com>
AntoineThebaud
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Pyroscope lookup hooks (
useLabelNames,useLabelValues,useProfileTypes,useServices) sendstart/endin the request, but the time range was not part of their React QueryqueryKey. When the dashboard time range changed, the cached result for the old range was reused, so the dropdowns could show stale or missing labels, services, and profile types.Changes
startandendto the query key of all four hooks, so a new time range triggers a new lookup.Follow-up to #835 (comment)
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.