Skip to content

[BUGFIX] Show annotation markers when the Y-axis excludes zero #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayush-that wants to merge 4 commits into from
Closed

[BUGFIX] Show annotation markers when the Y-axis excludes zero #838

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dd184e
Show annotation markers when the Y-axis excludes zero
ayush-that Sep 26, 2026
b2a62a3
Merge main into annotation-marker-visible
ayush-that Sep 28, 2026
49120b2
Merge branch 'main' into annotation-marker-visible
ayush-that Oct 5, 2026
7361c9c
Merge branch 'main' into annotation-marker-visible
ayush-that Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions timeserieschart/src/TimeSeriesChartBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,16 @@ export const TimeSeriesChartBase = forwardRef<ChartInstance, TimeChartProps>(fun
// empty array because a `null` value will throw an error.
if (data === null || (data.length === 0 && noDataVariant === 'message')) return noDataOption;

// If yAxis is already an array (multiple Y axes), use it directly; otherwise use getFormattedAxis
const visibleYAxes = Array.isArray(yAxis) ? yAxis : getFormattedAxis(yAxis, format);
const anchoredAnnotationSeries = annotationSeries.map((series) => ({
...series,
yAxisIndex: visibleYAxes.length,
}));
const updatedSeriesMapping =
enablePinning && pinnedCrosshair !== null
? [...seriesMapping, pinnedCrosshair, ...annotationSeries, ...exemplarSeries]
: [...seriesMapping, ...annotationSeries, ...exemplarSeries];
? [...seriesMapping, pinnedCrosshair, ...anchoredAnnotationSeries, ...exemplarSeries]
: [...seriesMapping, ...anchoredAnnotationSeries, ...exemplarSeries];

const option: EChartsCoreOption = {
dataset: dataset,
Expand All @@ -359,8 +365,7 @@ export const TimeSeriesChartBase = forwardRef<ChartInstance, TimeChartProps>(fun
snap: false, // important so shared crosshair does not lag
},
},
// If yAxis is already an array (multiple Y axes), use it directly; otherwise use getFormattedAxis
yAxis: Array.isArray(yAxis) ? yAxis : getFormattedAxis(yAxis, format),
yAxis: annotationSeries.length ? [...visibleYAxes, { type: 'value', show: false, min: 0, max: 1 }] : visibleYAxes,
animation: false,
tooltip: {
show: true,
Expand Down
Loading