refactor(roots): extract root resolution into internal/roots#61
Open
sm-stripe wants to merge 1 commit into
Open
refactor(roots): extract root resolution into internal/roots#61sm-stripe wants to merge 1 commit into
sm-stripe wants to merge 1 commit into
Conversation
Move profile-aware root resolution logic from cmd/bumblebee/roots.go into the importable internal/roots package so other binaries in this repo can share it without duplicating code. cmd/bumblebee behavior is unchanged — roots.go delegates to the new package and roots_compat.go forwards unexported names for existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary and Motivation
Making bumblebee's logic importable will enable new capabilities such as creating a bumblebee osquery extension without duplicating code.
This PR moves profile-aware root resolution logic from
cmd/bumblebee/roots.gointo the importableinternal/rootspackage.cmd/bumblebee/roots.gobecomes a thin delegate.cmd/bumblebee/roots_compat.goforwards unexported names for existing test compatibilitycmd/bumblebee behavior is unchanged — roots.go delegates to the new package and roots_compat.go forwards unexported names for existing tests.
Test plan
go build ./cmd/bumblebee— unchangedgo test -race ./...— all passgo vet ./...— cleangofmt -l .— no outputbumblebee selftest— passes