Python SDK Function for PDP List Role Assignments - #64
Closed
maya-barak wants to merge 1 commit into
Closed
maya-barak wants to merge 1 commit into
maya-barak wants to merge 1 commit into
Conversation
RazcoDev
reviewed
Apr 11, 2024
| params.update(dict(user=user)) | ||
| if role is not None: | ||
| params.update(dict(role=role)) | ||
| if tenant is not None: |
Contributor
There was a problem hiding this comment.
Missing resource condition
RazcoDev
reviewed
Apr 11, 2024
Comment on lines
+68
to
+69
| class SyncEnforcer(PdpApi, metaclass=SyncClass): | ||
| pass |
RazcoDev
reviewed
Apr 11, 2024
| resource_instance: Optional[str] = None, | ||
| page: int = 1, | ||
| per_page: int = 100, | ||
| ) -> dict: |
RazcoDev
reviewed
Apr 11, 2024
|
|
||
| Usage example: | ||
|
|
||
| permit = Permit(token |
RazcoDev
reviewed
Apr 11, 2024
|
|
||
|
|
||
| async def test_permission_check_e2e(permit: Permit): | ||
|
|
RazcoDev
reviewed
Apr 11, 2024
| logger.info("testing bulk permission check") | ||
| assert ( | ||
| await permit.bulk_check( | ||
| await permit.pdp_api.list_role_assignment( |
RazcoDev
reviewed
Apr 11, 2024
RazcoDev
left a comment
RazcoDev
left a comment
Contributor
There was a problem hiding this comment.
Some major comments - also, no interfaces ?
Contributor
|
Thanks @maya-barak for starting this. Listing role assignments from the PDP was a feature worth having. It was finished in #65, and #71 added sync-client support; both shipped in permit 2.4.0. So I'm closing this PR as superseded. The API is: # async
await permit.pdp_api.role_assignments.list(
user_key=..., role_key=..., tenant_key=...,
resource_key=..., resource_instance_key=...,
page=1, per_page=100,
) # -> List[RoleAssignment]
# sync (permit.sync.Permit)
permit.pdp_api.role_assignments.list(user_key=...)It includes the #126, now merged to main and shipping in permit 3.0.0, also fixes two bugs in it: the sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.