Repository navigation
Conversation
Tools that never get a tool_context reach the user's tokens through the call that before_tool_callback binds in a contextvar. That only holds while ADK runs the callback and the tool body in the same context, one per call. Nothing drove that through ADK's own dispatch, so a release that moved the callback elsewhere would have left every such tool without a token, with the unit tests still passing. 🤖 Generated with Claude Code
The range stopped at 2.9, and 2.9 holds opentelemetry-api at 1.42.1, which has a published advisory fixed in 1.45.1. ADK 2.14 allows 1.45.2. The 2.10 to 2.14 changes were checked against what gete relies on. The OpenAPI query style and SSRF changes are in RestApiTool's request path, which gete does not use: it takes only the declaration and sends through its own client. Instruction templating now substitutes less. No gete tool takes Enum arguments. The bound tool call still reaches each tool body, which the previous commit now tests through ADK's own dispatch. google-genai moves to 2.34.0 because ADK 2.14 requires it. 🤖 Generated with Claude Code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the google-adk range from
<2.10to<2.15, and locks 2.14.0.The range stopped at 2.9, and ADK 2.9 caps opentelemetry-api at 1.42.1. That version has a published advisory (GHSA-xcq7-p3pf-p88h, fixed in 1.45.1). ADK 2.14 allows 1.45.2, so this clears it.
What moves in the lock
ADK 2.10 to 2.14 against what gete relies on
The range is pinned because ADK changes tool behaviour between minor releases, so these were checked one by one:
style/explode; SSRF protection, path-parameter checks and 401 recovery in RestApiTool. All of these are in RestApiTool's request path. gete takes only the function declaration from RestApiTool and sends requests through its own client, so none of them change what gete sends.${var}and\{var}as written. This only narrows substitution.after_tool_callbackcan screen tool output;on_tool_errorruns on cancellation;McpToolsetusesMcpTool. gete's redaction, error and MCP tests pass unchanged.before_tool_callbackand the tool call context. Tools that never get atool_contextreach the user's tokens through the call thatbefore_tool_callbackbinds in a contextvar. Nothing tested that through ADK's own dispatch, so the first commit adds a test: two calls in one turn, run concurrently by ADK, each see only their own call. I made it fail by having the callback bind nothing, then saw it pass on both 2.9.2 and 2.14.0.google-cloud-aiplatform[adk](the Agent Engine base,<2) acceptsgoogle-adk<3, so deployed agents can resolve 2.14.Checks
uv lock --check,ruff check,ruff format --check, mypy, pytest (1027 passed, no warnings), andgete validate --import-checkon the example, which installs the deployment requirements in a fresh environment. All pass locally.