feat(unit-testing): Add axe-core support in ng-unit-testing library for accessibility testing utilities#130
Open
david-d-k wants to merge 10 commits into
Open
feat(unit-testing): Add axe-core support in ng-unit-testing library for accessibility testing utilities#130david-d-k wants to merge 10 commits into
axe-core support in ng-unit-testing library for accessibility testing utilities#130david-d-k wants to merge 10 commits into
Conversation
david-d-k
changed the title
axe-core support in ng-unit-testing library for accessibility testing utilities
glenstaes
requested changes
Apr 24, 2026
MarkCuypersPpw
requested changes
Apr 27, 2026
MarkCuypersPpw
left a comment
MarkCuypersPpw
left a comment
Contributor
There was a problem hiding this comment.
I suggest that the 2nd commit is split up in 2 commits:
- 1 that fixes the A11y issues in our components.
- 1 that adds the new unit tests to prevent A11y issues.
david-d-k
force-pushed
the
feature/a11y-unit-testing
branch
from
946e606 to
ec2f293
Compare
added 2 commits
July 6, 2026 10:36
david-d-k
force-pushed
the
feature/a11y-unit-testing
branch
from
ec2f293 to
a7fa7ed
Compare
glenstaes
reviewed
Jul 6, 2026
| <mat-progress-bar | ||
| mode="indeterminate" | ||
| type="progressbar" | ||
| [aria-label]="'common-components.loader.loading' | translate" |
Member
There was a problem hiding this comment.
As discussed through Slack, we'll need a way to provide these keys.
…using `axe-core` and Playwright
… testing utilities
glenstaes
changed the title
axe-core support in ng-unit-testing library for accessibility testing utilitiesaxe-core support in ng-unit-testing library for accessibility testing utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ppwcode/ng-unit-testing.