Add transparent AlfredPay quote pricing metadata - #1323
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard canceled.
|
ebma
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds diagnostic AlfredPay offramp pricing metadata while preserving existing quote arithmetic.
Changes:
- Persists reference, provider gross/net, fee, and customer all-in pricing observations.
- Adds source-aware fiat-rate snapshots and stricter AlfredPay response validation.
- Bumps the offramp flow to v3 with tests and security documentation.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/shared/src/services/alfredpay/schemas.ts |
Validates provider rate and fee type. |
packages/shared/src/services/alfredpay/schemas.test.ts |
Tests required pricing fields. |
docs/security-spec/05-integrations/alfredpay.md |
Documents pricing invariants. |
docs/security-spec/03-ramp-engine/ramp-phase-flows.md |
Documents flow v3. |
apps/api/src/tests/corridors/mxn-offramp.scenario.test.ts |
Verifies persisted pricing metadata. |
apps/api/src/test-utils/fake-world/fake-prices.ts |
Fakes source-aware rate snapshots. |
apps/api/src/api/services/priceFeed.service.ts |
Adds fiat-rate snapshot metadata. |
apps/api/src/api/services/priceFeed.service.test.ts |
Tests source, timestamp, and caching. |
apps/api/src/api/services/phases/blocks/phases/alfredpay-offramp/simulation.ts |
Calculates pricing observations. |
apps/api/src/api/services/phases/blocks/flows/alfredpay-offramp.ts |
Advances the flow to v3. |
apps/api/src/api/services/phases/blocks/__tests__/alfredpay-offramp.registration.test.ts |
Updates registration fixtures. |
apps/api/src/api/services/phases/blocks/__tests__/alfredpay-offramp.flow.test.ts |
Verifies v3 fail-closed identity handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Deployment note
Drain pre-v3 AlfredPay offramp quotes and in-flight ramps before deployment. Persisted older flow identities intentionally fail closed.