Add quiet config option#181
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details🔇 Additional comments (2)
📝 WalkthroughWalkthroughAdds a ChangesQuiet mode for logging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/root.go`:
- Around line 454-455: The startup banner is still printed to journald because
rootCmdRun calls printLogo() unconditionally; update rootCmdRun (or printLogo)
to respect config.Get().Quiet so the banner is skipped when Quiet is true.
Specifically, either wrap the printLogo() call in rootCmdRun with a check like
if !config.Get().Quiet before calling it, or modify printLogo() to return early
when config.Get().Quiet is true, ensuring log.SetLevel alone doesn't allow the
ASCII banner to be emitted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fe3bd540-9614-4aef-885e-ee0c46ddd62f
📒 Files selected for processing (2)
cmd/root.goconfig/config.go
Signed-off-by: Nikolaos Karaolidis <nick@karaolidis.com>
Useful when running as a systemd service, prevents journal polution. Alternative is a log-level option, but that would conflict with the already existing debug flag. I'll leave the choice up to the maintainers.
Summary by CodeRabbit