Skip to content

BUG-999359: show "No records found" message in simple table when filter retu… #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4manasa merged 1 commit into from
Jun 16, 2026
Merged

BUG-999359: show "No records found" message in simple table when filter retu… #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-sdk-components/src/components/field/RadioButtons/RadioButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export default function RadioButtons(props: RadioButtonsProps) {
inline,
displayMode,
hideLabel,
fieldMetadata
fieldMetadata,
disabled
} = props;
const [theSelectedButton, setSelectedButton] = useState(value);

Expand Down Expand Up @@ -102,7 +103,7 @@ export default function RadioButtons(props: RadioButtonsProps) {
localePath,
thePConn.getLocaleRuleNameFromKeys(localeClass, localeContext, localeName)
)}
control={<Radio key={theOption.key} color='primary' disabled={readOnly} />}
control={<Radio key={theOption.key} color='primary' disabled={readOnly || disabled} />}
/>
);
})}
Expand Down
4 changes: 3 additions & 1 deletion ...dk-components/src/components/template/SimpleTable/SimpleTableManual/SimpleTableManual.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,9 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
})}
</TableBody>
</Table>
{((readOnlyMode && (!rowData || rowData?.length === 0)) || (editableMode && (!referenceList || referenceList?.length === 0))) && (
{((readOnlyMode && (!rowData || rowData?.length === 0)) ||
(editableMode && (!referenceList || referenceList?.length === 0)) ||
(allowEditingInModal && (!rowData || rowData?.length === 0))) && (
<div className='no-records' id='no-records'>
{getGenericFieldsLocalizedValue('CosmosFields.fields.lists', 'No records found.')}
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-sdk-components/tests/e2e/Digv2/ComplexFields/DataReference.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ test.describe('E2E test', () => {

selectedTestName = page.locator('div[data-test-id="6f64b45d01d11d8efd1693dfcb63b735"]');
await selectedTestName.click();
await page.locator('li:has-text("Table")').click();
await page.getByRole('option', { name: 'Table', exact: true }).click();

selectedProduct = page.locator('tr:has-text("Basic Product")');
const selectedProductRow = selectedProduct.locator('input[type="radio"]');
Expand Down
4 changes: 2 additions & 2 deletions packages/react-sdk-components/tests/e2e/Digv2/FormFields/Attachment.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ test.describe('E2E test', () => {

/** Delete attachment */
await menuSelector.locator('li >> text="Delete"').click();
await expect(page.locator('div >> text="cableinfo.jpg"')).toBeVisible();
await expect(page.locator('div >> text="cablechat.jpg"')).toBeHidden();
await expect(page.locator('div >> text="cableinfo.jpg"')).toBeHidden();
await expect(page.locator('div >> text="cablechat.jpg"')).toBeVisible();
}, 10000);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/react-sdk-components/tests/e2e/Digv2/FormFields/URL.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ test.describe('E2E test', () => {
await expect(attributes.includes('readonly')).toBeFalsy();

/** Validation tests */
const validationMsg = 'Please enter a valid URL including the protocol (http://, https://, ftp://, etc.)';
const validationMsg = 'Please enter a valid URL including the protocol (http://, https:// etc.)';
await editableURL.fill('InvalidUrl');
await editableURL.blur();
await expect(page.locator(`p:has-text("${validationMsg}")`)).toBeVisible();
Expand Down
Loading