fix: restore parse-domain-update bin dropped during template merge - #239
Merged
Conversation
commit: |
There was a problem hiding this comment.
Pull request overview
Restores the npm package metadata required to ship and expose the parse-domain-update CLI and TypeScript declarations, which were accidentally removed during a template merge. This brings the published package back in line with the existing build output (dist/bin/update.js) and the README guidance to run npx parse-domain-update.
Changes:
- Re-adds the
binmapping forparse-domain-updatepointing to./dist/bin/update.js. - Restores the top-level
typesentry pointing to./dist/main.d.ts. - Updates
package-lock.jsonto reflect the packagebinmetadata.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Restores bin and types fields so the CLI and typings are published/resolvable again. |
| package-lock.json | Updates lock metadata to match the restored bin entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🎉 This PR is included in version 8.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"bin"and"types"fields frompackage.json.parse-domain-updateCLI from the published package, even thoughdist/bin/update.jsis still built (npm run build:updateruns it) and referenced in the README.npx parse-domain-updateworks again.Fixes #238
Test plan
npm run build— builds successfully,dist/bin/update.jsexists and runs the smoke testnode ./dist/bin/update.jsruns and downloads/serializes the PSL as expectednpm testpasses (suite, lint, types, format, jsr dry-run)