Skip to content

fix: restore parse-domain-update bin dropped during template merge - #239

Merged
jhnns merged 1 commit into
mainfrom
restore-removed-bin
Aug 11, 2026
Merged

fix: restore parse-domain-update bin dropped during template merge#239
jhnns merged 1 commit into
mainfrom
restore-removed-bin

Conversation

@jhnns

@jhnns jhnns commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • The template merge in e93f249 accidentally dropped the "bin" and "types" fields from package.json.
  • This silently removed the parse-domain-update CLI from the published package, even though dist/bin/update.js is still built (npm run build:update runs it) and referenced in the README.
  • Restores both fields so npx parse-domain-update works again.

Fixes #238

Test plan

  • npm run build — builds successfully, dist/bin/update.js exists and runs the smoke test
  • node ./dist/bin/update.js runs and downloads/serializes the PSL as expected
  • npm test passes (suite, lint, types, format, jsr dry-run)

The template merge in e93f249 accidentally dropped the "bin" and
"types" fields from package.json, removing the parse-domain-update
CLI even though dist/bin/update.js is still built and referenced by
the build:update script.

Fixes #238
Copilot AI lite review requested due to automatic review settings August 11, 2026 23:43
@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/parse-domain@239

commit: a831a96

@jhnns
jhnns merged commit 70710e3 into main Aug 11, 2026
4 checks passed
@jhnns
jhnns deleted the restore-removed-bin branch August 11, 2026 23:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the npm package metadata required to ship and expose the parse-domain-update CLI and TypeScript declarations, which were accidentally removed during a template merge. This brings the published package back in line with the existing build output (dist/bin/update.js) and the README guidance to run npx parse-domain-update.

Changes:

  • Re-adds the bin mapping for parse-domain-update pointing to ./dist/bin/update.js.
  • Restores the top-level types entry pointing to ./dist/main.d.ts.
  • Updates package-lock.json to reflect the package bin metadata.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Restores bin and types fields so the CLI and typings are published/resolvable again.
package-lock.json Updates lock metadata to match the restored bin entry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 95.094%. remained the same — restore-removed-bin into main

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 8.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Was parse-domain-update removed intentionally in v8.3.2?

3 participants