Repository navigation
fix: seeded mock generation now gives the same output on every run - #654
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 309 309
Lines 39208 39213 +5
=========================================
+ Hits 39208 39213 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another mock determinism fix to plug the gaps still left over to make pb33f/doctor#119 changes deterministic.
Seeded mock generation now gives the same output on every run. Dates and times come from a fixed UTC instant instead of the clock, UUIDs come from the seed instead of crypto/rand, and XML children flattened with nodeType: none follow the schema's order instead of Go's random map order.
I built one spec that hits every branch of the renderer:
Each of the 13 changed lines on v0.41.5 was one of the three fixes: dateTime, time, uuid (including a uuid nested inside allOf), or a flattened nodeType: none child that moved position. Nothing else changed.
Code audit: