Repository navigation
test: cover composed reference collision fallback - #652
Merged
Merged
Conversation
daveshanley
marked this pull request as ready for review
October 6, 2026 16:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
========================================
Coverage 99.99% 100.00%
========================================
Files 301 301
Lines 38415 38415
========================================
+ Hits 38414 38415 +1
+ Misses 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the last missed line in
resolveRefToComposed: applying a collision name to an external reference when its processed entry has no composed location. Reuses the existing multi-file fixture and checks the exact rewritten reference.Validation: full suite with network tests enabled reaches 100.0% statement coverage with zero uncovered blocks; focused race check passes. Replacing the fallback with the original reference makes the new test fail. Independent correctness and de-slop reviews found no issues.
Risk: low. One test added; production code is unchanged.