Repository navigation
Fix document diagnostics with the pb33f JSON Schema fork - #332
Merged
Merged
Conversation
daveshanley
marked this pull request as ready for review
October 6, 2026 14:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 98.36% 98.27% -0.10%
==========================================
Files 79 80 +1
Lines 9433 9481 +48
==========================================
+ Hits 9279 9317 +38
- Misses 129 139 +10
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the pb33f JSON Schema fork based on upstream v6.0.3, with fixes for overwritten error locations and missing flattened reference errors. Use the published v6.0.3 tag without a local replacement, and update libopenapi to v0.41.3.
Document validation now reports invalid property names at the exact key, with the correct name, source location, and escaped path. It retains unrelated validation failures and omits generic error groups. Regression tests cover OpenAPI 3.1 and 3.2, repeated and escaped names, non-pattern constraints, boolean schemas, arrays, nested content constraints, and sibling failures.
Consumers that use JSON Schema types directly must change their imports to
github.com/pb33f/jsonschema/v6; the fork has distinct Go type identities. The README describes this migration.Validation: full tests and race tests pass; lint reports zero issues. Total coverage is 98.7%, and all three new diagnostic helpers have 100% statement coverage. Independent correctness and code-cleanup reviews found no remaining blockers.
Uses the fixes merged in pb33f/jsonschema#1. Replaces #315.