Skip to content

Fix document diagnostics with the pb33f JSON Schema fork - #332

Merged
daveshanley merged 2 commits into
mainfrom
codex/jsonschema-6-0-3-compat
Oct 6, 2026
Merged

daveshanley merged 2 commits into
mainfrom
codex/jsonschema-6-0-3-compat

Conversation

@daveshanley

@daveshanley daveshanley commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Use the pb33f JSON Schema fork based on upstream v6.0.3, with fixes for overwritten error locations and missing flattened reference errors. Use the published v6.0.3 tag without a local replacement, and update libopenapi to v0.41.3.

Document validation now reports invalid property names at the exact key, with the correct name, source location, and escaped path. It retains unrelated validation failures and omits generic error groups. Regression tests cover OpenAPI 3.1 and 3.2, repeated and escaped names, non-pattern constraints, boolean schemas, arrays, nested content constraints, and sibling failures.

Consumers that use JSON Schema types directly must change their imports to github.com/pb33f/jsonschema/v6; the fork has distinct Go type identities. The README describes this migration.

Validation: full tests and race tests pass; lint reports zero issues. Total coverage is 98.7%, and all three new diagnostic helpers have 100% statement coverage. Independent correctness and code-cleanup reviews found no remaining blockers.

Uses the fixes merged in pb33f/jsonschema#1. Replaces #315.

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (4290880) to head (806500f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   98.36%   98.27%   -0.10%     
==========================================
  Files          79       80       +1     
  Lines        9433     9481      +48     
==========================================
+ Hits         9279     9317      +38     
- Misses        129      139      +10     
  Partials       25       25              
Flag Coverage Δ
unittests 98.27% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
daveshanley merged commit b1808fe into main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant