-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(plugin-search): reindex documents published in non-default locales #17550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrikKozak
wants to merge
3
commits into
main
Choose a base branch
from
fix/plugin-search-reindex-localized-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−11
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
810fd8d
fix(plugin-search): reindex documents published in non-default locales
PatrikKozak d32af41
chore: scope reindex sync to published locale to avoid all-locales fi…
PatrikKozak 30da269
chore(plugin-search): scope reindex sync to published locale
PatrikKozak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any concern about overhead on larger indexing jobs with this extra fetch? I'm not sure if there are implications to consider. If so, we could probably do one
payload.findper locale for all the known doc IDs instead of one per doc per localeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about that. The extra
findByIDisO(docs × locales), which is the same order as the per-locale writes we're already doing, so it's more of a constant-factor bump on what's already a manual, transactional job - shouldn't be scary for normal-sized collections.The thing is, when
beforeSyncis set (which is most configs)syncDocAsSearchIndexalready refetches per doc per locale anyway, so batching a find-by-IDs would only cut the handler's reads, not that inner one. To actually win there we'd need to pass the scoped doc into sync and let it skip its own refetch, and that touches the live hook path.Could add the batching but open to other's thoughts