Skip to content

fix(ui): keep form modified after any failed submit, not just drafts #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikhana wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

fix(ui): keep form modified after any failed submit, not just drafts #17534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/ui/src/forms/Form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,15 +459,14 @@ export const Form: React.FC<FormProps> = (props) => {
setProcessing(false)
setSubmitted(true)

// The document was not persisted, so keep the form marked as modified
// to keep the save buttons enabled for retry.
setModified(true)

// When there was an error submitting a draft,
// set the form state to unsubmitted, to not trigger visible form validation on changes after the failed submit.
// Also keep the form as modified so the save button remains enabled for retry.
if (overridesFromArgs['_status'] === 'draft') {
setModified(true)

if (!validateDrafts) {
setSubmitted(false)
}
if (overridesFromArgs['_status'] === 'draft' && !validateDrafts) {
setSubmitted(false)
}

contextRef.current = { ...contextRef.current } // triggers rerender of all components that subscribe to form
Expand Down
Loading