Repository navigation
fix(ChatbotModal): Drop custom styles - #943
Conversation
|
Preview: https://chatbot-pr-chatbot-943.surge.sh A11y report: https://chatbot-pr-chatbot-943-a11y.surge.sh |
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Looks good to me; thank you for the extra tests! Just one question for Kayla.
| } | ||
|
|
||
| .pf-chatbot__chatbot-modal { | ||
| --pf-v6-c-modal-box--BorderRadius: var(--pf-t--global--border--radius--medium) !important; |
There was a problem hiding this comment.
@kaylachumley - do you have feelings about this? It means that there's a slight bit of the ChatBot visible underneath.
There was a problem hiding this comment.
hmmm yeah i dont love that the border radius doesnt match perfectly.. what's causing that? is there a custom border radius on the chatbot panel itself thats mismatching it? wdyt? @andrew-ronaldson
There was a problem hiding this comment.
Yes! ChatBot has its own border radius. We can change it to match modal if you'd prefer!
There was a problem hiding this comment.
Updated the chatbot panel, inner container, and conversation-history backdrop to use the large border radius, it's now matching PatternFly’s modal default as suggested.
Existing square corners in other display modes are unchanged.
There was a problem hiding this comment.
that update is fine with me and @andrew-ronaldson ! I will need to update the figma file to match these border radius changes. Originally it was at 16px but now the change reflected is 24px (large border radius) for overlay chatbot panel and modals. thank you!
|
🎉 This PR is included in version 6.10.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Remove shared modal color, typography, border-radius, and header/footer presentation overrides so ChatbotModal follows base PatternFly styles and can adapt to Felt changes.
Preserve chatbot-specific positioning, sizing, backdrop behavior, compact styling, and the glass-theme code-modal background fix from #925.
Add tests covering display modes, custom classes, and backdrop behavior.
Validation:
Fixes #932
Jira: https://redhat.atlassian.net/browse/FELT-4406