Repository navigation
Release SourceBraid for iOS 1.1.1 - #22
Merged
Merged
Conversation
Signed-off-by: Patrick Schiller <p@trickschiller.de>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a731567551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an iPhone reader that could remain loading after returning to the list and opening a second article. Prepares SourceBraid for iOS 1.1.1 (build 12), independently of the existing plugin release PR.
The reader now keeps its navigation identity, guards stale loads, resets document-specific UI state and reports interrupted or invalid UTF-8 reads. Interrupted archive bootstrap resumes; local Mermaid rendering, Apple Intelligence availability guidance, Recent/Zuletzt naming and Settings cleanup are included. English/German App Store copy and 22 native screenshots are already saved in the 1.1.1 draft.
Privacy and permissions: no new GitHub scopes, credential storage, archive-format changes or remote diagram service. Mermaid runs from the pinned app bundle in an isolated WebKit world; document scripts stay disabled and external article images still require explicit consent. Upstream licenses and exact bundle bytes are retained.
Validation: 58 unit/integration tests and 14 UI executions passed for the functional patch, including the reproducible first-open-only reader regression. The exact 1.1.1/build 12 checkout also passed all 58 unit tests and both critical reader/Mermaid UI cases. Unsigned Release device and generic Simulator builds passed; both packaged bundles passed the iOS validator at 1.1.1/build 12. Core suites passed 23 Node and 64 Python tests. GitHub Release checks and DCO are green. Actual Cloud archive/upload and Apple submission will be recorded separately.
After merging, the existing main-branch Xcode Cloud workflow should produce build 12. The maintainer has authorized submitting matching version 1.1.1 for App Review after processing. The existing manual App Store release setting remains unchanged.