Update wpad.cpp

[patchzyy]

Fixed soft drifting by fixing the wpad data format

Summary by CodeRabbit

• Bug Fixes
  • Corrected the reported data format for valid Wii Remote channels based on the connected controller type. Invalid channels continue to return an error.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 01967ddc-a76f-4c15-a898-8c050cb0b47e

📥 Commits

Reviewing files that changed from the base of the PR and between 16bfe7b and fe39806.

📒 Files selected for processing: 1

• runtime/src/hle/input/wpad.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

WPADGetDataFormat_HLE now returns contract errors unchanged and selects a format for valid channels based on WiiRemoteInput::EffectiveKind.

Changes: WPAD data format selection

Layer / File(s)	Summary
Validate channel and select format runtime/src/hle/input/wpad.cpp	The function preserves negative contract results. For valid channels, it returns 5 for Nunchuk, 8 for Classic Controller, or 2 for other kinds.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to fe398

WPAD format selection now follows the effective controller kind, with no concrete guest-visible regression established. No actionable merge-blocking risk remains.

Pre-merge checks: 3 · 1 · 1

Failed checks: 1 warning · 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check		The title identifies the changed file but does not describe the main change: correcting the WPAD data format to fix soft drifting.	Use a specific title such as "Correct WPAD data format for controller input".

Passed checks: 3 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}